[feat]: Packed reader multi files test #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaoting-huang
force-pushed
the
packed_test
branch
from
6fbd6c1 to
ff96888
Compare
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
packed_test
branch
from
e3459ef to
321ad6d
Compare
tedxu
reviewed
Jan 10, 2025
go/packed/packed_reader.go
Outdated
Comment on lines
45
to
49
| cNeedColumns := (*C.int)(C.malloc(C.size_t(len(opt.needColumns)) * C.size_t(unsafe.Sizeof(C.int(0))))) | ||
| for i, col := range opt.needColumns { | ||
| (*[1<<31 - 1]C.int)(unsafe.Pointer(cNeedColumns))[i] = C.int(col) | ||
| } | ||
| cNumNeededColumns := C.int(len(opt.needColumns)) |
There was a problem hiding this comment.
This is too much for my small heart. Can we make it simpler? The needed columns can be just a bitset with several words.
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
changed the title
Signed-off-by: shaoting-huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #158